Repository navigation
feat(atemschutz): name a Trupp by Funkrufname and Trupp-Art - #769
Merged
Merged
Conversation
- Funkrufname suggestions are the Kräfte entered for the Einsatz, whatever their Status, instead of every vehicle in the Stammdaten. The box stays free text (#92). - A Trupp is called "{Funkrufname} · {Trupp-Art}" everywhere: grid, banners, ETB lines, Sicherheitstrupp picker and Bericht. The running number stays stored for ordering only. - The TRUPP column grows from 190 to 240px and the name wraps. - "Si." is written out as "Sicherheitstrupp"; in the Bericht it moves to the full-width sub-line, where the word fits unbroken. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four change requests for the Atemschutz page, in one PR:
{Funkrufname} · {Trupp-Art}, e.g.Florian Musterstadt 40/1 · Angriffstrupp, or justAngriffstruppwithout a Funkrufname. This name is used in the grid, the banners, the ETB lines, the Sicherheitstrupp picker and the hint.TruppNumberis still stored and used for ordering, so there is no migration and no sync change. The name is computed rather than stored, so existing Einsatzdateien show the new form. ETB lines already written keep their text.DisplayNameWithCallSignis now the same asDisplayName, so it is removed.Two Trupps with the same Funkrufname and Trupp-Art now carry the same name; their grid rows are still separate.
Known, not changed here
At 1280px with the nav rail, the grid already scrolls sideways on
main(AKTION is cut off; see the before shot).Atemschutz_grid_fits_without_scrolling_sidewaysmeasuresScbaViewwithout the rail, so it doesn't catch this. The extra 50px for TRUPP makes the scroll 50px longer. Fixing it means rebalancing the columns, which deserves its own PR.Screenshots
Before (1280px)

After (1280px)

Before (phone) / After (phone)

Verification
make clean ci: 0 errors, all test assemblies passed, noTest Run Failed.make format-check: clean.make mutate SINCE=origin/mainchanged-line scores: Domain 100 %, Documents 100 %, AppLogic 91.7 %.🤖 Generated with Claude Code